Conversation
crates/icp/src/canister/mod.rs
Outdated
| { | ||
| #[derive(Deserialize)] | ||
| #[serde(untagged)] | ||
| enum OneOf { |
Contributor
There was a problem hiding this comment.
Making this internal means that the schema can't see it. Can this function instead be formatted as a pub wrapper type which impls Deserialize and JsonSchema?
Contributor
Author
There was a problem hiding this comment.
It's now a pub wrapper type. How do you like the new version? Still gives a clunky impression to me, but I'd like to validate the amount the first time the type is constructed. Is there a nicer way to do it?
Contributor
There was a problem hiding this comment.
Looks good as is to me, but if you did want to make it cleaner, you could implement JsonSchema directly on a u64 newtype, since the enum structure is I think only there for schemars(untagged).
adamspofford-dfinity
approved these changes
Feb 20, 2026
…ycles-icp-yaml-inputs
raymondk
deleted the
SDK-2573-use-the-cycles-parser-for-all-the-cycles-icp-yaml-inputs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support cycles amount suffixes in
.yamlfiles